1.20: minor changes to java change notes#1117
Merged
Merged
Conversation
yh-semmle
suggested changes
Mar 18, 2019
| |----------------------------|------------------------|------------------------------------------------------------------| | ||
| | Arbitrary file write during archive extraction ("Zip Slip") (`java/zipslip`) | Fewer false positive results | Results involving a sanitization step that converts a destination `Path` to a `File` are no longer reported. | | ||
| | Double-checked locking is not thread-safe (`java/unsafe-double-checked-locking`) | Fewer false positive results and more true positive results | Results that use safe publication through a `final` field are no longer reported. Results that initialize immutable types like `String` incorrectly are now reported. | | ||
| | Double-checked locking is not thread-safe (`java/unsafe-double-checked-locking`) | Fewer false positive and more true positive results | Results that use safe publication through a `final` field are no longer reported. Results that initialize immutable types like `String` incorrectly are now reported. | |
Contributor
There was a problem hiding this comment.
It looks like this line can be removed because this query is introduced in this release, so this line should not have been added in the first place.
Contributor
Author
There was a problem hiding this comment.
Thanks. I should have spotted that.
Contributor
Author
|
Thanks for the review. I've removed the relevant line. |
yh-semmle
approved these changes
Mar 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of very minor changes to the notes in preparation for release.